Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SE-231] Events api added with tests #243

Merged
merged 3 commits into from
Sep 26, 2019
Merged

[SE-231] Events api added with tests #243

merged 3 commits into from
Sep 26, 2019

Conversation

sstaley-sparkpost
Copy link
Contributor

@sstaley-sparkpost sstaley-sparkpost commented Sep 25, 2019

Support for events-api. to query. To test manually, follow the examples in examples/search_message. Should support all query params for /api/v1/events/message.

You may need to change the url to the staging and/or test api to have an API key/cutomer_id that works. The customer_id header should be present in the object passed to the search function.

Copy link

@alice-haber alice-haber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good as far as I can tell. Definitely make sure to have someone more customer-facing look it over too, if you can.

@sstaley-sparkpost
Copy link
Contributor Author

Good as far as I can tell. Definitely make sure to have someone more customer-facing look it over too, if you can.

Gotchya, will do

Copy link
Contributor

@jgzamora jgzamora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@sstaley-sparkpost sstaley-sparkpost merged commit 85b768a into master Sep 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants