-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for EmailMessage.extra_headers and transactional option #160
Support for EmailMessage.extra_headers and transactional option #160
Conversation
Relates to SparkPost#159 EmailMessage.extra_headers land in custom_headers transmission param, and X-MSYS-API if present and has options.transactional == True will translate onto transactional transmission param.
…upport I put TODO in these and marked invalid statements for noqa, as they are generally ok
…upport, during debugging of DKIM signature validation problem with some messages Case ID# 203488 Payload dumping can be disabled with usual python logging configuration
Hi there! Can you provide a feedback on this PR? Can it be merged? |
@bizob2828, @aydrian, @richleland Can you provide a feedback on this PR? |
Hey @wooyek, sorry for the delay. We'll get the right 👀on this. @aydrian / @richleland are no longer maintainers for this repo |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @wooyek, thanks for the PR! I wasn't familiar with the library but I think we can ship this. Thanks for adding the linting fixes as well. Only 1 request:
Would you mind removing the extra logging added? I know it can be easily turned off, but I'd rather add something like that in a separate PR throughout the whole library.
With pleasure. Give a shout if you need something more. |
@wooyek I'm going to merge this. There may be a slight delay on releasing on PyPI while I'm becoming familiar with the process, but I hope to get it out today. Thanks again for the PR! |
Relates to #159
EmailMessage.extra_headers land in custom_headers transmission param,
and X-MSYS-API if present and has options.transactional == True will
translate onto transactional transmission param.