Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat : 랜덤 프로필 페이지 #15

Merged
merged 10 commits into from
May 6, 2024
Merged

Conversation

LeLu815
Copy link
Collaborator

@LeLu815 LeLu815 commented May 4, 2024

close #30

프로필 생성 페이지

  1. 랜덤 이미지 생성
  2. 유저 아이디
  3. 유저 비밀번호

해당 값을 로컬에 저장.
로컬에 정보가 있으면 불러옴.

@1eeyerin 1eeyerin self-assigned this May 4, 2024
@1eeyerin 1eeyerin added the enhancement New feature or request label May 4, 2024
@1eeyerin 1eeyerin assigned LeLu815 and unassigned 1eeyerin May 4, 2024
css/animate.css Outdated Show resolved Hide resolved
css/profile.css Outdated Show resolved Hide resolved
css/profile.css Outdated Show resolved Hide resolved
css/profile.css Show resolved Hide resolved
css/profile.css Show resolved Hide resolved
js/profile.js Outdated Show resolved Hide resolved
js/profile.js Show resolved Hide resolved
js/profile.js Outdated Show resolved Hide resolved
js/profile.js Outdated Show resolved Hide resolved
profile.html Outdated Show resolved Hide resolved
@LeLu815 LeLu815 changed the title Feature/random profile feat : 랜덤 프로필 이미지 페이지 May 4, 2024
@LeLu815 LeLu815 changed the title feat : 랜덤 프로필 이미지 페이지 feat : 랜덤 프로필 페이지 May 4, 2024
profile.html Outdated Show resolved Hide resolved
profile.html Outdated Show resolved Hide resolved
profile.html Outdated Show resolved Hide resolved
@1eeyerin
Copy link
Member

1eeyerin commented May 4, 2024

image
접혀진 부분의 코멘트도 확인 부탁드려요!

profile.html Outdated
/>
</div>
<div class="confirm_box">
<a href="index.html" id="cancel" type="button" class="btn cancel"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

type 지워주세요!

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

지웠습니다

profile.html Outdated
<div id="animate__zoomInDown" class="animate__animated">
<img
id="imgUrl"
style="width: 120px; height: 120px"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

인라인 스타일로 지정하신 이유가 있을까요? 관리 포인트가 늘어나기에 특별한 이유가 없다면 html에서 styling을 지양 부탁드립니다!

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

스타일링 바꿨습니다

profile.html Outdated
/>
</div>
</div>
<button class="createBtn" id="createRandomBtn">랜덤 생성</button>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이부분도 type=button 명시 부탁드립니다!

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

@1eeyerin 1eeyerin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

추가 코멘트만 수정 부탁드립니다!

@LeLu815 LeLu815 merged commit b44d9c7 into develop May 6, 2024
@LeLu815 LeLu815 deleted the feature/random_profile branch May 6, 2024 01:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

랜덤 프로필 페이지 구현
2 participants