Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: 댓글 삭제 구현 #23

Merged
merged 4 commits into from
May 7, 2024
Merged

feat: 댓글 삭제 구현 #23

merged 4 commits into from
May 7, 2024

Conversation

1eeyerin
Copy link
Member

@1eeyerin 1eeyerin commented May 6, 2024 •
edited
Loading

🍎 Issue Ticket

close #12

🍎 UI 구현 이미지

  • 댓글 삭제 기능
  • 본인 확인용 비밀번호 일치 확인
  • 모달 구현

🚨 공용 css 추가 🚨

css/common.css

  • .blind 스타일 추가하였습니다. (텍스트 리더기에서 읽힐 수 있도록 텍스트 없는 아이콘에 텍스트리더기에 추가하기 위함)

@1eeyerin 1eeyerin self-assigned this May 6, 2024
@1eeyerin 1eeyerin added the enhancement New feature or request label May 6, 2024
@Ahnjonghyun87
Copy link
Collaborator

l g t m

yeeunseo-dev
yeeunseo-dev reviewed May 6, 2024
View reviewed changes
Copy link
Collaborator

@yeeunseo-dev yeeunseo-dev left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

코드를 다 이해는 못하겠지만..
한번 구조는 보았습니다.. Look good to me 네요 :) ...

  • 물론 레퍼런스가 없긴하지만 버튼 컬러에 웨이브 블루 사용해서 통일감을 주면 어떨지요!

Ahnjonghyun87
Ahnjonghyun87 approved these changes May 7, 2024
View reviewed changes
Copy link
Collaborator

@Ahnjonghyun87 Ahnjonghyun87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lg t m

ARMJONG
ARMJONG approved these changes May 7, 2024
View reviewed changes
Copy link
Collaborator

@ARMJONG ARMJONG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

실제 서비스 가능할 정도로 UI 너무 깔끔하고 잘 만든것 같습니다. 코드도 너무 조아용

@1eeyerin 1eeyerin merged commit 32b861f into develop May 7, 2024
@1eeyerin 1eeyerin deleted the feature/review-delete branch May 7, 2024 05:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ARMJONG ARMJONG ARMJONG approved these changes

@Ahnjonghyun87 Ahnjonghyun87 Ahnjonghyun87 approved these changes

@yeeunseo-dev yeeunseo-dev yeeunseo-dev approved these changes

@LeLu815 LeLu815 Awaiting requested review from LeLu815

Assignees

@1eeyerin 1eeyerin

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

영화 리뷰 삭제하기
4 participants
@1eeyerin @Ahnjonghyun87 @ARMJONG @yeeunseo-dev