Feature/상세페이지 구현 #24
Merged
Feature/상세페이지 구현 #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1eeyerin
requested changes
May 6, 2024
|
.detail-view-content-area .detail-view-box .detail-info-table .genre { |
1eeyerin
approved these changes
May 6, 2024
added 2 commits
May 7, 2024 00:50
yeeunseo-dev
approved these changes
May 7, 2024
| background-repeat: no-repeat; | ||
| width: 100%; | ||
| height: 100%; | ||
| z-index: 10; |
There was a problem hiding this comment.
z-index값이 어떤 역할하는지 궁금합니다! 저는 큰 차이없어서 지우기도 했어서욤
There was a problem hiding this comment.
::before라는 효과 때문에 썼습니다 저도 웨이브 클론 css하면서 알게된건데 예를들면 얇은 셀로판지 두게 깔아두고 z 값으로 a와 b중 어떤게 더 앞으로 부각될지 조절하는 값이라고 합니다
css/detail.css
Outdated
|
|
||
| .detail-info-box { | ||
| width: 780px; | ||
|
|
ARMJONG
approved these changes
May 7, 2024
감사합니다 암종현님도 따봉스 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #22
detail.js에서 import 해온 detail 정보에 인물 관련 정보가 없어서
절취선 밑에 따로 api를 가져오는 함수를 gpt4파워로 썼습니다
현재는 상세정보와 인물 정보가 id 1094844로 맞춰진 상태인데
메인화면에서 카드를 클릭해서 가져오는 id 값이 밑의 credit api의 fetch에서도 동일하게 바꿔주는 작업까진 해야 합니다