Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat : 팝업 기능 구현 #26

Merged
merged 7 commits into from
May 8, 2024
Merged

feat : 팝업 기능 구현 #26

merged 7 commits into from
May 8, 2024

Conversation

LeLu815
Copy link
Collaborator

@LeLu815 LeLu815 commented May 6, 2024

close #20

popup.js
popup.css
index.html 파일 안에 구현함.
(바디를 화면 전체로 확장하기 위해 부득히하게 잠깐 inline 스타일로 100vh,vw 설정함)

일주일간 보지 않기를 누르고 삭제하면 1주일 만료로 쿠키에 저장됨
일주일간 보지 않기를 누르지 않고 삭제하면 새로고침시 팝업창이 다시 생성됨

Copy link
Collaborator

@Ahnjonghyun87 Ahnjonghyun87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

l g t mmmmmm

Copy link
Collaborator

@yeeunseo-dev yeeunseo-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

코드를 다 이해하진 못했지만
잘 읽었습니다 :)

border-radius: 8px;
}
.main-outer {
width: 508px;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

혹시 이 여백은 의도하신걸까용?

index.html Outdated Show resolved Hide resolved
css/popup.css Outdated Show resolved Hide resolved
css/popup.css Outdated Show resolved Hide resolved
css/popup.css Outdated Show resolved Hide resolved
index.html Outdated Show resolved Hide resolved
index.html Outdated
<a class="main-content" href="#">
<img
src="https://image.wavve.com/v1/thumbnails/0_0_20_80/service30/crm/auth_firstbenefit_layerpopup_pc.jpg"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Img 아래 줄 띄워짐

Copy link
Collaborator

@ARMJONG ARMJONG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

주석처리 잘 해주셔서 이해가 편했습니다

index.html Outdated Show resolved Hide resolved
Copy link
Collaborator

@Ahnjonghyun87 Ahnjonghyun87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

popup.js에서 많이 배웠습니다 고생하셨습니다

Copy link
Collaborator

@Ahnjonghyun87 Ahnjonghyun87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다 lgtm!

@LeLu815 LeLu815 merged commit df5601f into develop May 8, 2024
@LeLu815 LeLu815 deleted the feature/popup-cookie branch May 8, 2024 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

쿠키를 이용한 광고 팝업 구현
5 participants