Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: theme이 dom 그리기 전에 적용되게 한다 #74

Merged
merged 1 commit into from
May 9, 2024

Conversation

1eeyerin
Copy link
Member

@1eeyerin 1eeyerin commented May 9, 2024

fliker 현상 방어를 위한 수정

  • script type=module은, 항상 defer를 넣은 것처럼 지연실행 된다.
  • html이 다 준비된 이후에 실행된다.
  • html 로딩 이후 html을 한줄 한줄 읽는다.
  • css가 가장 앞에 있어 css를 먼저 적용한다.
  • 그 다음 type=module이 적힌 스크립트를 실행하기에 theme이 default값에서 뒤 늦게 실행이 된다

@1eeyerin 1eeyerin added the bug Something isn't working label May 9, 2024
@1eeyerin 1eeyerin self-assigned this May 9, 2024
Copy link
Collaborator

@yeeunseo-dev yeeunseo-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

감사합니당!

page/nowplaying.html Show resolved Hide resolved
@1eeyerin 1eeyerin merged commit ef83d85 into develop May 9, 2024
@1eeyerin 1eeyerin deleted the feature/theme-sync-loading branch May 9, 2024 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants