-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: 영화 댓글 작성하기 기능 구현 #9
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1eeyerin
force-pushed
the
feature/movie-review
branch
2 times, most recently
from
May 4, 2024 17:18
1e19d78
to
0e85a0d
Compare
잘 봤습니다 |
LeLu815
approved these changes
May 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
큰 문제는 없어보입니다
lgtm |
깔끔하게 잘 정리하셔서 보기 편했습니다! 수고하셨습니다 |
* submit handler 추가 * submit 시 localstorage 로 저장 * star rating click event 함수 구현 * 관련 util 함수 구현 * form 유효성 검사
* 목록 render 함수 추가 * 기존 mockup html 제거 * css var 사용
1eeyerin
force-pushed
the
feature/movie-review
branch
from
May 6, 2024 03:41
8941f92
to
58f2a4e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🍎 Issue Ticket
close #3
🍎 UI 구현 이미지
🍎 localStorage 에 comments 객체 배열 추가
🚨 공용 함수 추가 🚨
js/utils/
localStorage.js
js/utils/
getUrlParamValue.js
🍎 Structure
js/review/
index.js
js/review/
utils.js
js/review/reviewList/
getMovieReviews.js
js/review/reviewList/
renderMovieReviews.js
js/review/reviewForm/
isValidReviewValues.js
js/review/reviewForm/
reviewFormSubmitHandler.js
js/review/reviewForm/
addReviewToLocalStorage.js
js/review/reviewForm/
reviewRatingClickHandler.js