Merge pull request #171 from solarispika/fix/precompose-filename-fail…

…-easily Fix precomposeFileName buffer overflow issue
SpartanJ · Nov 23, 2023 · bc85baf · bc85baf
2 parents aae269e + a0db6e9
commit bc85baf
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/src/efsw/FileSystem.cpp b/src/efsw/FileSystem.cpp
@@ -1,6 +1,6 @@
+#include <cstring>
 #include <efsw/FileSystem.hpp>
 #include <efsw/platform/platformimpl.hpp>
-#include <cstring>
 
 #if EFSW_OS == EFSW_OS_MACOSX
 #include <CoreFoundation/CoreFoundation.h>
@@ -107,7 +107,7 @@ std::string FileSystem::precomposeFileName( const std::string& name ) {
 		return std::string();
 	}
 
-	std::string result( maxSize, '\0' );
+	std::string result( maxSize + 1, '\0' );
 	if ( CFStringGetCString( cfMutable, &result[0], result.size(), kCFStringEncodingUTF8 ) ) {
 		result.resize( std::strlen( result.c_str() ) );
 		CFRelease( cfStringRef );