Fixup cmake exports #177
Merged
Fixup cmake exports #177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Shauren
commented
Jun 3, 2024
Shauren
commented
- Add missing find_dependency calls to efswConfig.cmake.in
- Removed duplicated efswTargets.cmake and efsw-staticTargets.cmake generation both of them contained all targets so -static file was dropped (this is the safe approach that preserves current behavior even if this isn't what was intended)
* Add missing find_dependency calls to Config.cmake.in
* Removed duplicated efswTargets.cmake and efsw-staticTargets.cmake generation
both of them contained all targets so -static file was dropped (this is the safe approach that preserves current behavior even if this isn't what was intended)
|
Also a request related to my cmake fixups - would it be possible to create a new version tag so that this library can be updated in vcpkg? |
|
Thank you very much for your contribution. I added the new tag as you requested. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.