Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only open file in read-mode, because it's only going to be read. #2175

Merged
merged 1 commit into from Apr 25, 2019

Conversation

vroomfondle
Copy link
Contributor

Requirements

Please take note of our contributing guidelines: https://laravel-excel-docs.dev/docs/3.0/getting-started/contributing
Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.

Mark the following tasks as done:

  • Checked the codebase to ensure that your feature doesn't already exist.
  • Checked the pull requests to ensure that another person hasn't already submitted the feature or fix.
  • Adjusted the Documentation.
  • Added tests to ensure against regression.

Description of the Change

When reading from a file in order to create a temporary copy, open the file in 'read' mode instead of read/write.

Why Should This Be Added?

See #2159 - opening in read/write mode can cause permissions errors.

Benefits

Fewer permissions errors!

Possible Drawbacks

Verification Process

Imported a file which only has read permissions set. It worked.

Applicable Issues

#2159

@patrickbrouwers patrickbrouwers merged commit dfe75ae into SpartnerNL:3.1 Apr 25, 2019
@patrickbrouwers
Copy link
Member

Thanks @vroomfondle !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants