Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added FromGenerator support #2394

Merged
merged 3 commits into from
Oct 11, 2019
Merged

Added FromGenerator support #2394

merged 3 commits into from
Oct 11, 2019

Conversation

mixisLv
Copy link
Contributor

@mixisLv mixisLv commented Oct 10, 2019

Requirements

Please take note of our contributing guidelines: https://docs.laravel-excel.com/3.1/getting-started/contributing.html
Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.

Mark the following tasks as done:

  • Checked the codebase to ensure that your feature doesn't already exist.
  • Checked the pull requests to ensure that another person hasn't already submitted the feature or fix.
  • Adjusted the Documentation.
  • Added tests to ensure against regression.

Description of the Change

Added FromGenerator support (https://www.php.net/manual/en/language.generators.syntax.php#control-structures.yield)

Why Should This Be Added?

Useful to export large collections data structure and save memory.

Benefits

Useful to export large collections data structure and save memory.

Possible Drawbacks

Verification Process

Applicable Issues

Copy link
Member

@patrickbrouwers patrickbrouwers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, thanks for submitting this PR. This functionality was on my TODO-list, so happy someone added it!

Can you also add a test for the FromGenerator functionality and PR the docs with this new addition. Thanks.

src/Concerns/FromGenerator.php Outdated Show resolved Hide resolved
Copy link
Member

@patrickbrouwers patrickbrouwers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will merge it after documentation is updated. Thanks!

@mixisLv
Copy link
Contributor Author

mixisLv commented Oct 11, 2019

Docs: SpartnerNL/laravel-excel-docs#86

@patrickbrouwers patrickbrouwers merged commit e4fcf05 into SpartnerNL:3.1 Oct 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants