Feature/refactor config local path #3329
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposal to improve the temporary_files->local_path configuration in the default config/excel.php file:
'temporary_files' => [
]
because under the current configuration, there will be tmp files appearing in Git local changes.
i think we need to ignore it in git config.
And to make it simpler, I think I can change the path to put in the cache folder, it's quite reasonable.
We can change the light storage_path('framework/cache/laravel-excel') instead of storage_path('framework/laravel-excel')