Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding InteractsWithQueue to AppendToSheet jobs (fixes: #3365) #3366

Merged
merged 4 commits into from
Sep 27, 2021

Conversation

lk77
Copy link
Contributor

@lk77 lk77 commented Sep 16, 2021

Hello

1️⃣ Why should it be added? What are the benefits of this change?

this fixes #3365 by adding InteractsWithQueue trait to AppendToSheet jobs (Data/Query/View)

i've renamed ReadChunkTest to a more generic InteractsWithQueueTest and added test for each job to check for the trait presence like the existing test for ReadChunk job.

2️⃣ Does it contain multiple, unrelated changes? Please separate the PRs out.

it's related to the release issue

3️⃣ Does it include tests, if possible?

yes

4️⃣ Any drawbacks? Possible breaking changes?

No breaking change

5️⃣ Mark the following tasks as done:

  • Checked the codebase to ensure that your feature doesn't already exist.
  • Take note of the contributing guidelines.
  • Checked the pull requests to ensure that another person hasn't already submitted a fix.
  • Added tests to ensure against regression.
  • Updated the changelog

i'm proposing to add those laravel traits because it seems they are needed when using WithoutOverlapping queue middleware,
but i don't know if this trait is missing somewhere else than Append*ToSheet jobs.

thanks.

@patrickbrouwers patrickbrouwers merged commit ffc9e39 into SpartnerNL:3.1 Sep 27, 2021
@lk77 lk77 deleted the 3.1 branch October 9, 2021 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Error: Call to undefined method Maatwebsite\Excel\Jobs\AppendQueryToSheet::release()
2 participants