Adding InteractsWithQueue to AppendToSheet jobs (fixes: #3365) #3366
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello
1️⃣ Why should it be added? What are the benefits of this change?
this fixes #3365 by adding InteractsWithQueue trait to AppendToSheet jobs (Data/Query/View)
i've renamed ReadChunkTest to a more generic InteractsWithQueueTest and added test for each job to check for the trait presence like the existing test for ReadChunk job.
2️⃣ Does it contain multiple, unrelated changes? Please separate the PRs out.
it's related to the release issue
3️⃣ Does it include tests, if possible?
yes
4️⃣ Any drawbacks? Possible breaking changes?
No breaking change
5️⃣ Mark the following tasks as done:
i'm proposing to add those laravel traits because it seems they are needed when using WithoutOverlapping queue middleware,
but i don't know if this trait is missing somewhere else than Append*ToSheet jobs.
thanks.