-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add configuration option to configure permissions of local temporary directory (and files) #3767
Conversation
@patrickbrouwers if you could check the code if this is an acceptable solution. Default directory permissions seem the be different when creating directories under Travis, I'm not sure how to fix this (yet). |
@patrickbrouwers PR #3804 applies to |
Thanks, sorry it's taking so long. Having a crazy busy time, so haven't gotten the chance to really dive into this yet. |
This bug report has been automatically closed because it has not had recent activity. If this is still an active bug, please comment to reopen. Thank you for your contributions. |
This bug report has been automatically closed because it has not had recent activity. If this is still an active bug, please comment to reopen. Thank you for your contributions. |
This bug report has been automatically closed because it has not had recent activity. If this is still an active bug, please comment to reopen. Thank you for your contributions. |
This bug report has been automatically closed because it has not had recent activity. If this is still an active bug, please comment to reopen. Thank you for your contributions. |
Please take note of our contributing guidelines: https://docs.laravel-excel.com/3.1/getting-started/contributing.html
Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
1️⃣ Why should it be added? What are the benefits of this change?
The current code doesn't use the configured permissions of Laravel filesystem. See #3766
2️⃣ Does it contain multiple, unrelated changes? Please separate the PRs out.
No.
3️⃣ Does it include tests, if possible?
Yes, a new test was added to test the behaviour of
TemporaryFileFactory
4️⃣ Any drawbacks? Possible breaking changes?
Code is backwards compatible
5️⃣ Mark the following tasks as done:
6️⃣ Thanks for contributing! 🙌