Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add configuration option to configure permissions of local temporary directory (and files) #3767

Merged
merged 10 commits into from
Nov 6, 2023

Conversation

svenbw
Copy link
Contributor

@svenbw svenbw commented Oct 20, 2022

Please take note of our contributing guidelines: https://docs.laravel-excel.com/3.1/getting-started/contributing.html
Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.

1️⃣ Why should it be added? What are the benefits of this change?
The current code doesn't use the configured permissions of Laravel filesystem. See #3766

2️⃣ Does it contain multiple, unrelated changes? Please separate the PRs out.
No.

3️⃣ Does it include tests, if possible?
Yes, a new test was added to test the behaviour of TemporaryFileFactory

4️⃣ Any drawbacks? Possible breaking changes?
Code is backwards compatible

5️⃣ Mark the following tasks as done:

  • Checked the codebase to ensure that your feature doesn't already exist.
  • Take note of the contributing guidelines.
  • Checked the pull requests to ensure that another person hasn't already submitted a fix.
  • Added tests to ensure against regression.
  • Updated the changelog

6️⃣ Thanks for contributing! 🙌

@svenbw
Copy link
Contributor Author

svenbw commented Oct 20, 2022

@patrickbrouwers if you could check the code if this is an acceptable solution.

Default directory permissions seem the be different when creating directories under Travis, I'm not sure how to fix this (yet).

@patrickbrouwers
Copy link
Member

Hey @svenbw does this PR #3804 have any implications on yours?

@svenbw
Copy link
Contributor Author

svenbw commented Dec 5, 2022

@patrickbrouwers PR #3804 applies to RemoteTemporaryFile my changes apply to LocalTemporaryFile, so there is no conflict between both PR's

@patrickbrouwers
Copy link
Member

patrickbrouwers commented Dec 9, 2022

Thanks, sorry it's taking so long. Having a crazy busy time, so haven't gotten the chance to really dive into this yet.

@stale
Copy link

stale bot commented Mar 6, 2023

This bug report has been automatically closed because it has not had recent activity. If this is still an active bug, please comment to reopen. Thank you for your contributions.

@stale stale bot closed this Mar 6, 2023
@stale stale bot removed the stale label Mar 6, 2023
@stale stale bot added the stale label May 5, 2023
@stale
Copy link

stale bot commented May 7, 2023

This bug report has been automatically closed because it has not had recent activity. If this is still an active bug, please comment to reopen. Thank you for your contributions.

@stale stale bot closed this May 7, 2023
src/Files/TemporaryFileFactory.php Show resolved Hide resolved
config/excel.php Outdated Show resolved Hide resolved
config/excel.php Outdated Show resolved Hide resolved
tests/Helpers/FileHelper.php Show resolved Hide resolved
@stale
Copy link

stale bot commented Oct 28, 2023

This bug report has been automatically closed because it has not had recent activity. If this is still an active bug, please comment to reopen. Thank you for your contributions.

@stale stale bot closed this Oct 28, 2023
@stale
Copy link

stale bot commented Oct 31, 2023

This bug report has been automatically closed because it has not had recent activity. If this is still an active bug, please comment to reopen. Thank you for your contributions.

@stale stale bot closed this Oct 31, 2023
@stale stale bot removed the stale label Oct 31, 2023
@patrickbrouwers patrickbrouwers merged commit d79e663 into SpartnerNL:3.1 Nov 6, 2023
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants