Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Laravel 10 #3860

Merged
merged 7 commits into from
Jan 26, 2023
Merged

Support Laravel 10 #3860

merged 7 commits into from
Jan 26, 2023

Conversation

freekmurze
Copy link
Contributor

Please take note of our contributing guidelines: https://docs.laravel-excel.com/3.1/getting-started/contributing.html
Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.

1️⃣ Why should it be added? What are the benefits of this change?

Laravel 10 will be amazing!

2️⃣ Does it contain multiple, unrelated changes? Please separate the PRs out.

Nope, just Laravel 10 support!

3️⃣ Does it include tests, if possible?

Yes, the test will run on the shiny new version of our favourite framework.

4️⃣ Any drawbacks? Possible breaking changes?

Nope, let's goooooo!

5️⃣ Mark the following tasks as done:

  • Checked the codebase to ensure that your feature doesn't already exist.
  • Take note of the contributing guidelines.
  • Checked the pull requests to ensure that another person hasn't already submitted a fix.
  • Added tests to ensure against regression.
  • Updated the changelog

6️⃣ Thanks for contributing! 🙌

@freekmurze
Copy link
Contributor Author

I tried a couple of things to make the tests pass, but failed to do so.

Hopefully you have a good idea to make it work on L10.

@patrickbrouwers patrickbrouwers merged commit 4b5162d into SpartnerNL:3.1 Jan 26, 2023
@patrickbrouwers
Copy link
Member

All green now, thanks

@freekmurze
Copy link
Contributor Author

Great! 🙌 Could you tag a release for this?

@patrickbrouwers
Copy link
Member

Tagged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants