Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update composer OR in constraints to use newer double pipe #4022

Merged
merged 2 commits into from
Oct 31, 2023

Conversation

jessiegreen
Copy link
Contributor

Please take note of our contributing guidelines: https://docs.laravel-excel.com/3.1/getting-started/contributing.html
Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.

1️⃣ Why should it be added? What are the benefits of this change?
I was unable to composer require maatwebsite/excel:^3.1 with Composer version 2.6.1 and PHP 8.2.10 getting "maatwebsite/excel 3.1.0 requires php ^7.0 -> your php version (8.2.10) does not satisfy that requirement" with the single pipe.

2️⃣ Does it contain multiple, unrelated changes? Please separate the PRs out.
No

3️⃣ Does it include tests, if possible?
N/A

4️⃣ Any drawbacks? Possible breaking changes?
This is the latest and should not break anything

5️⃣ Mark the following tasks as done:

  • [x ] Checked the codebase to ensure that your feature doesn't already exist.
  • [x ] Take note of the contributing guidelines.
  • [x ] Checked the pull requests to ensure that another person hasn't already submitted a fix.
  • [x ] Added tests to ensure against regression.

6️⃣ Thanks for contributing! 🙌

@patrickbrouwers
Copy link
Member

Are you sure that has to do with the pipes and not with the fact that you might be missing a php ext that is required by newer php spreadsheet versions? Do you know the difference beteeen | and || ?

@jessiegreen
Copy link
Contributor Author

jessiegreen commented Oct 31, 2023 via email

@patrickbrouwers
Copy link
Member

Awesome, sounds like this will solve a major pain. Thanks for testing it and linking the relevant documentation!

@patrickbrouwers patrickbrouwers merged commit f4bae9a into SpartnerNL:3.1 Oct 31, 2023
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants