Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Symfony 2.3 support #29

Merged
merged 1 commit into from
May 23, 2013
Merged

Symfony 2.3 support #29

merged 1 commit into from
May 23, 2013

Conversation

jankramer
Copy link

Currently SpBowerBundle won't install in SF-2.3 projects, so I updated the version constraints in the composer.json file.

@Spea
Copy link
Owner

Spea commented May 23, 2013

~2.1 is a little bit too much as this would also support every version up to 3.0. Change it to >=2.1,<2.4-dev please

@jankramer
Copy link
Author

That was exactly what I was aiming for ;-) As of symfony 2.3, there should be no more BC breaks until 3.0, so in theory SpBowerBundle should already be compatible automatically with <3.0 if it's compatible with 2.3.

Of course, this choice is a matter of opinion, so if you still want the tighter version constraint, I'll adjust it.

@Spea
Copy link
Owner

Spea commented May 23, 2013

I see, it's ok then. Thanks for your contribution ;)

Spea added a commit that referenced this pull request May 23, 2013
@Spea Spea merged commit 745a2be into Spea:master May 23, 2013
@jankramer
Copy link
Author

Np and thanks for the quick merge!

@jankramer jankramer deleted the symfony-2.3 branch May 23, 2013 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants