Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix createDependencyMappingCache for bower 1.0+ #40

Closed
wants to merge 1 commit into from

Conversation

jankramer
Copy link

The method createDependencyMappingCache throws a MappingException when using bower 1.0+ because since this version bower list --map returns a formatted string instead of JSON by default. By using the --json option, bower is forced to return a JSON-string.

The method createDependencyMappingCache fails with bower 1.0
because since this version ```bower list --map``` does not return
JSON by default anymore. Therefore, the ```--json``` has been added.
@Spea
Copy link
Owner

Spea commented Jul 26, 2013

Thanks, I will take a look at this PR over the weekend

@jankramer
Copy link
Author

By the way: the changelog states that --map is removed, but when running sp:bower:install it looks like unknown options are just ignored. I did a few tests and the adding of --json indeed works on both bower 0.x and bower 1.x, but this is perhaps not the cleanest solution.

Perhaps a good point to start working towards a 1.0 release and remove the --map option?

@Spea
Copy link
Owner

Spea commented Jul 29, 2013

Yeah you are right, I will work towards 1.0 and remove all deprecated/removed things. I think it is time for a 1.0 release of this bundle aswell :)

@omissis
Copy link

omissis commented Aug 1, 2013

Hi, I just hit this issue too :)

@Spea
Copy link
Owner

Spea commented Aug 1, 2013

I'm currently working on a new version, should be finished this week

@jankramer
Copy link
Author

Great! Looking forward to it! :)

@Spea
Copy link
Owner

Spea commented Aug 4, 2013

I still struggle with the json of the dependency mapping. A lot has changed in 1.0, so it will take a little longer then I thought, hopefully no more than 3 days.

@Spea
Copy link
Owner

Spea commented Aug 8, 2013

Sorry for the delay. I just pushed new changes to the master branch. Pleas try this version and let me know if you have any more issues. I will prepare a 1.0 release in the next days.

@Spea Spea closed this Aug 8, 2013
@jankramer
Copy link
Author

👍 I did some quick tests, and It works like a charm, thx! No worries about the delay, I appreciate the effort you put into this bundle! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants