Improve property access and added post processing #13
Conversation
…rocess generated array
| "symfony/options-resolver": "~2.1", | ||
| "symfony/filesystem": "~2.1", | ||
| "phpcollection/phpcollection": "0.2.*", | ||
| "symfony/filesystem": "3.0.*", |
| "symfony/property-access": "~2.2", | ||
| "jms/cg": "1.0.0" | ||
| "jms/cg": ">=1.0.0" |
There was a problem hiding this comment.
This would also allow version 2, 3, etc. So you should use ~1.0 instead
| protected $skipNullValues = false; | ||
|
|
||
|
|
||
|
|
| * User: andreasschacht | ||
| * Date: 01.08.16 | ||
| * Time: 11:27 | ||
| */ |
| * @return array | ||
| */ | ||
| public function getData($object, ClassMetaData $metadata, array $data); | ||
| } |
There was a problem hiding this comment.
Please make sure that you always add a new line at the end of a file. Since you use PHPStorm, there is an option you can activate
| * @return mixed | ||
| */ | ||
| public function getValue($object, $property); | ||
| } |
| * | ||
| * @return boolean true, if this class can process the data | ||
| */ | ||
| public function isSupporting($object, ClassMetaData $metadata, array $data); |
There was a problem hiding this comment.
Would call this method just supports
|
Thx for this PR, but make sure that the tests are running again ;) |
|
Thanks, I fixed it and renamed the method name. I had to restrict the jms/cg version to be less than v1.2, because this version breaks your tests. It adds a newline to the DocBlock of the generated class (with the ClassFixtureGenerator), the versions before don't. So your string comparison will fail. |
|
https://github.com/Spea/fixture-dumper/releases/tag/v1.1.0 Here you go :) |
Hi,
I made some improvements, e.g. access to private/protected properties. I got a request to make a PR ans ask you, if you can merge and create a new release. So others can also use this approvements and install them via packagist.
Best regards