Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added: Common and helpful interaction and extension methods (SpecFlow.Actions.Playwright, SpecFlow.Actions.Selenium). #64

Merged
merged 4 commits into from
Dec 23, 2021

Conversation

Sven-Seyfert
Copy link
Contributor

@Sven-Seyfert Sven-Seyfert commented Dec 6, 2021

Changelog

SpecFlow.Actions.Playwright

Added:

  • Common interaction method GetUrl() which is also implemented in the Selenium implementation.
    Useful for a comparison of the Selenium implementation versus the Playwright ones.
  • Interaction method GetUrl() to Readme.md file.

Changed:

  • String "Selenium" to "Playwright" in summary comment.

Removed:

  • Selenium package reference.

Tests:

  • All CalculatorFeature test scenarios still works (passed).

SpecFlow.Actions.Selenium

Added:

  • Common extension method MoveToElement() which moves the mouse/viewport to the specific element.
  • Extension method MoveToElement() to Readme.md file.

Changed:

  • Package update for ChromeDriver.
  • Var to Const.

Removed:

  • Conditional access qualifier, because the expression is known to be not null.

Tests:

  • All CalculatorFeature test scenarios still works (passed).
  • Also the Unit Tests still works (passed).

@Sven-Seyfert Sven-Seyfert changed the title Removed: Selenium package reference. Removed: Selenium package reference from SpecFlow.Actions.Playwright. Dec 6, 2021
….Actions.Playwright, SpecFlow.Actions.Selenium).
@Sven-Seyfert Sven-Seyfert changed the title Removed: Selenium package reference from SpecFlow.Actions.Playwright. Added: Common and helpful interaction and extension methods (SpecFlow.Actions.Playwright, SpecFlow.Actions.Selenium). Dec 6, 2021
@Sven-Seyfert
Copy link
Contributor Author

Sorry the second commit should actually be a second pull request but I missed it.
Anyway, I am pretty sure you will handle it 🤞 .

@JordanWestern
Copy link
Contributor

Thanks @Sven-Seyfert we will take a look :)

@Sven-Seyfert
Copy link
Contributor Author

Sven-Seyfert commented Dec 10, 2021

@JordanWestern

Update

I added the ChromeDriver package update.

My guess why it breaks

Maybe the build error "dotnet test [...]" is caused by a missing package reference update:

grafik

I didn't commit my package update change which I made locally, because I thought it will be made automatically in the build pipeline.

ChromeDriver update
grafik

@SabotageAndi
Copy link
Contributor

Thanks for your contribution to SpecFlow.
Please submit your contributions to our SpecFlow Community Heroes program at https://specflow.org/community/submit-a-contribution/

@SabotageAndi SabotageAndi merged commit 1a6e921 into SpecFlowOSS:main Dec 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants