MSTest Static FeatureSetup on generated .feature.cs is a bug

[regisbsb]

I'm using MSTest.
Lets pretend you have 2 feature files.
Feature file A has two scenarios: scenario 1 and scenario 3.
Feature file B has one scenarios : test 2.
If you have run tests order by name it will run:
Feature A - scenario 1
Feature B - scenario 2
Feature A - scenario 3

The problem is that feature info is setup on line ~33 on the Feature A.feature.cs on static method FeatureSetup.
Calling testRunner.OnFeatureStart(featureInfo);
this static method is called only once I think.

Then the tests runs:
Feature A class is created. scenario 1 runs
Feature B is created. scenario 2 runs.
scenario 3 runs with the wrong feature context from feature b
So when you go back to Feature A - scenario 3 the ObjectContainer.FeatureContext.FeatureInfo is from Feature B.
Then it messes all the StepScoped step definition. I use FeatureInfo to initialize my CSS selector helpers.
A lot of my tests are falling on a random basis depending on the order they run.

I suggest you to change the generator to write TestInitializeAttribute instead of ClassInitializeAttribute before the FeatureSetup method on .feature.cs files. So the feature info is always right.
Maybe is the same problem of #95 issue.

Thank you.

[regisbsb]

You can find an example http://regis.ws/specflow/TestProject1.zip
In my example you have 2 feature files and each have 2 scenarios that depend on FeatureInfo.Title to work.
If you run the tests together and the order of tests mixes tests from diferent feature files 1 test always fail.

[gasparnagy]

i see the problem...
changing the ClassInitializeAttribute to TestInitializeAttribute is not so easy, as this would lead to running all before/after feature specflow event to run before/after each scenario... we need a smarter way, that somehow checks if the current feature is still the current one and run the logic only if it is not...

[regisbsb]

We could have one method just for kicking specflow event on ClassInitializeAttribute and another method on TestInitializeAttribute just for setting the FeatureContext.
I've tried to setup my enviroment to provide a full fix but without success.
The main ideia is to split FeatureSetup into 2 methods decorated with ClassInitializeAttribute, and other one with TestInitializeAttribute.
That should do the job.

[gasparnagy]

I think i have a fix for this now, you can test it through the build site (build.specflow.org)

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.