Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug - CSD task - saving prompt to affect CO record #3764

Closed
AntWeb-org opened this issue Jan 8, 2024 · 23 comments
Closed

Bug - CSD task - saving prompt to affect CO record #3764

AntWeb-org opened this issue Jan 8, 2024 · 23 comments
Assignees
Labels
bug An existing function is broken.

Comments

@AntWeb-org
Copy link

Steps to reproduce the bug

1.In the CSD task
2.Made update/added data to Attributes/Custom Attributes field and pressed Save
3.Prompt suggesting that the collecting event was modified and will affect all CO records associated with that CE.
4.Went to Edit collecting event for good measure and did not make any changes
5.Pressed Save although no updates/changes were made
6.Another prompt suggesting changes to CE will affect associated COs.
...

Screenshot

Prompt in CSD record/no updates made to CE record:
CSD

Prompt in CE records/no updates made to CE record:
EditCE

Expected behavior

It seems that there is an issue with one specific (as far as I know) CO and associated CE (CASENT0042899/BLF09800). I tested and saved other records and did not experience that issues.

I did not make any updates to that CE record and cancelled the updates to the CO record. I am wary of that prompt and do not know if anything will affect the CO records for that CE.

Additional Screenshots

No response

Environment

Production

Sandbox Used

No response

Version

v0.37.1

Browser Used

Chrome Version 120.0.6099.131

@AntWeb-org AntWeb-org added the bug An existing function is broken. label Jan 8, 2024
@jlpereira jlpereira self-assigned this Jan 8, 2024
@AntWeb-org
Copy link
Author

Update: happening in other CO records in the CSD when I attempt to add data into a Custom Attribute field.

@tmcelrath
Copy link

This is also happening when you try to create a brand new collecting event from comprehensive. Instead of creating a new one it is editing the old one. NEEDS A HOT FIX ASAP.

@tmcelrath
Copy link

Weirdly - even though you are prompted that it will "edit >100 records" it does not actually do so.

@tmcelrath
Copy link

Upon refresh, the CE is created as normal, even though client-side, pre-refresh, it looks like it you are editing a CE with >100 records.

@AntWeb-org
Copy link
Author

So can I click Edit and hope for the best or should I hold off until the issue is fully resolved? I'm still a little hesitant.

@tmcelrath
Copy link

At least from my end everything has all been client-side visual and is not actually making changes to the CE with >100 records unless you are actually doing so. It's very confusing and @jlpereira has said he will try to fix it today.

@AntWeb-org
Copy link
Author

That's great! Thank you!

@jlpereira
Copy link
Member

jlpereira commented Jan 10, 2024

@AntWeb-org where do you add the custom attributes? To the collection object or to the collecting event?

@AntWeb-org
Copy link
Author

I was adding to the CO in the CSD, specifically for CASENT0042899 under Attributes.
Thanks!

@jlpereira
Copy link
Member

Were you editing other collection objects without leaving the interface? Does this happen if it is the first collection object you load when you open the interface?

@AntWeb-org
Copy link
Author

Someone else was making an update to that specific specimen initially. I checked to see if it was done. When I realized it was not done I made the update and then received the Edit message. I was not happening previously for other COs I updated and I do not think I was updating in separate tabs. It was not happening on the first CO.

@tmcelrath
Copy link

For me - it gives me the warning if I go to any CO that has a CE with >100 records. If I edit anything on the record (even if not in CE), then I get warning.

@tmcelrath
Copy link

Secondarily - if I remove the CE with >100 objects, and create a new one - it tells me that I am editing the CE with >100 COs. If I save, it even looks like the CE has been edited. If I refresh the page however, that disappears.

@AntWeb-org
Copy link
Author

I guess I was editing COs with CEs that have fewer than 100 COs associated. Weird.

@jlpereira
Copy link
Member

I think I found the problem and already solved it, in a moment I will be pushing it.

@AntWeb-org
Copy link
Author

Thank you!

@mjy
Copy link
Member

mjy commented Jan 10, 2024

Can someone confirm if this is visual, of if it could really affect the data because of editing a record you didn't think you should be editing?

@tmcelrath
Copy link

Visual.

@tmcelrath
Copy link

Extremely confusing, but visual.

@mjy
Copy link
Member

mjy commented Jan 10, 2024

Heard. I panicked big time on somethign like this the other day too...

@AntWeb-org
Copy link
Author

Unfortunately, the problem has returned even before I add any collecting event to a new CSD that I am entering. Notice the Attributes as still locked. It began happening steadily at this point on my fifth or sixth entry.

image

@jlpereira
Copy link
Member

@AntWeb-org this fix is not yet in production

@AntWeb-org
Copy link
Author

Got it, thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An existing function is broken.
Projects
None yet
Development

No branches or pull requests

4 participants