Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Left and right arrow keys on task hub don't work as expected #3792

Closed
kleintom opened this issue Jan 22, 2024 · 4 comments
Closed

[Bug]: Left and right arrow keys on task hub don't work as expected #3792

kleintom opened this issue Jan 22, 2024 · 4 comments
Labels
bug An existing function is broken.

Comments

@kleintom
Copy link
Contributor

Steps to reproduce the bug

1. Go to the task hub /hub?list=tasks
2. On my standard screen I see 3 columns of tasks by 4 rows of tasks.
3. Now press the right arrow key.

Actual results:
The black squares representation at the top of the screen of what tasks I'm currently viewing only moves ahead by 4 squares (which matches the tasks I see on screen). i.e. I'm now viewing tasks 5-16. See the screenshot.

Expected results:
Tasks 13-24 are displayed.

The left arrow key has the same issue, it only moves by 4 tasks at a time.

Screenshot

Screenshot 2024-01-22 at 11-18-21 TaxonWorks - Hub

Expected behavior

No response

Additional Screenshots

No response

Environment

Development (docker)

Sandbox Used

No response

Version

No response

Browser Used

No response

@kleintom kleintom added the bug An existing function is broken. label Jan 22, 2024
@jlpereira
Copy link
Member

@mjy how was this expected to work? Move one column at a time or change all cards?

@mjy
Copy link
Member

mjy commented Jan 22, 2024

Initial intent was to page columns one at a time. I think @LordFlashmeow commented on related behaviour too in another issue IIRC. I'm pretty impartial to 1 colum vs 1 page, so if there are a couple more votes for this let's change it.

@kleintom
Copy link
Contributor Author

I don't have a strong preference either, but I'll just add that, although current behavior is to shift by the size of a column, it actually does that across rows (not column); in other words if there are 4 rows (so a column has length 4) and each row has 3 items then when you press the right arrow the top row shifts off and the first item in the second row shifts off (a total of 4 items, the length of a column, gets shifted off). So the red in the screenshot will shift away when you press the right arrow:

image

To me that makes it kind of difficult to track how far you need to look through the current cards to see all of the ones that are going to disappear the next time you press the right arrow. The rows vs. columns: number of each vs length of each is confusing to me, was it maybe intended to shift off an entire row for each arrow press?

@jlpereira
Copy link
Member

Aha, now I understand what you mean. I think this started happening when we changed the direction of the flex grid from column to row, so that the alphabetical order of the cards starts from left to right. I think the "easiest" ways to fix this might be to move by row instead of column, or swap all the cards.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An existing function is broken.
Projects
None yet
Development

No branches or pull requests

3 participants