Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused agi code #445

Merged
merged 2 commits into from Feb 28, 2024
Merged

Remove unused agi code #445

merged 2 commits into from Feb 28, 2024

Conversation

juggernot325
Copy link
Contributor

Description

This PR removes some database function (and the corresponding mock functions) that are no longer used across the code base for tidiness.

I also updated the CreateAssetGroupSelector API client function to use a PUT instead of a POST as the latter has been deprecated. While fixing this I noticed that the response body didn't match the struct we were trying to parse into, so I updated that to match as well.

Motivation and Context

  • Clean code is happy code

How Has This Been Tested?

  • Existing tests still pass

Types of changes

  • Chore (a change that does not modify the application functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • Documentation updates are needed, and have been made accordingly.
  • I have added and/or updated tests to cover my changes.
  • All new and existing tests passed.
  • My changes include a database migration.

Copy link
Contributor

@mistahj67 mistahj67 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thanks for cleaning these up! 🧹 🧼

@juggernot325 juggernot325 merged commit 2ceb295 into main Feb 28, 2024
3 checks passed
@juggernot325 juggernot325 deleted the remove-unused-agi-code branch February 28, 2024 21:52
@github-actions github-actions bot locked and limited conversation to collaborators Feb 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants