fix: plumb context into client db methods #450
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Plumb context into gorm client db methods
https://gorm.io/docs/context.html#Context-Timeout
Motivation and Context
Currently as it stands any endpoints that rely on purely gorm do not respect
request.Context
and as such timeouts are not respected either. While we want to eventually get to the removal of the gorm dependency altogether, that is a long way and a lot of effort away and this I think this approach would give us that much room to maneuver while we get there.How Has This Been Tested?
Using a rest client and the prefer header
Add a sleep inside of the handler
Look for the
500 request timed out
after exceeding the timeout. (Note: the request will take as long as the sleep is set, it's not tied to the prefer header)Types of changes
Checklist: