Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: typescript error with assetGroupId #473

Merged
merged 13 commits into from Mar 7, 2024
Merged

Conversation

brandonshearin
Copy link
Contributor

Description

our CI doesn't catch typescript related errors when PRs build. as a result, there was a type error related to assetGroupId's that went into main. the correct type for this is a number, so several places that were previously treating that value as a string needed an update!

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Chore (a change that does not modify the application functionality)
  • [ x] Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • Documentation updates are needed, and have been made accordingly.
  • I have added and/or updated tests to cover my changes.
  • All new and existing tests passed.
  • My changes include a database migration.

@brandonshearin brandonshearin enabled auto-merge (squash) March 7, 2024 18:51
@brandonshearin brandonshearin merged commit c3cce2c into main Mar 7, 2024
3 checks passed
@brandonshearin brandonshearin deleted the fix-ts-for-selector branch March 7, 2024 19:03
@github-actions github-actions bot locked and limited conversation to collaborators Mar 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants