Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move graph deletion to datapipe #517

Merged
merged 6 commits into from Mar 22, 2024
Merged

Conversation

rvazarkar
Copy link
Contributor

@rvazarkar rvazarkar commented Mar 22, 2024

Description

Moves logic for graph deletion to the datapipe to prevent deadlocks

Motivation and Context

The existing logic for clearing the DB was handled by the api handler in resources. However, if concurrent graph modifications were being performed in datapipe, this would lead to graph deadlocks. This MR moves the graph deletion logic into datapipe

https://specterops.atlassian.net/browse/BED-4286

How Has This Been Tested?

Local testing

Screenshots (if appropriate):

Types of changes

  • Chore (a change that does not modify the application functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • Documentation updates are needed, and have been made accordingly.
  • I have added and/or updated tests to cover my changes.
  • All new and existing tests passed.
  • My changes include a database migration.

justfile Show resolved Hide resolved
Copy link
Contributor

@juggernot325 juggernot325 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did have a couple questions, but it's likely they won't require code changes. I'm preemptively approving under the assumption that nothing further will be needed. If that changes I'll revoke the approval.

@sircodemane sircodemane added bug Something isn't working api A pull request containing changes affecting the API code. labels Mar 22, 2024
@superlinkx superlinkx merged commit e774e08 into stage/v5.8.0 Mar 22, 2024
3 checks passed
@superlinkx superlinkx deleted the datapipe_graph_deletion branch March 22, 2024 20:36
@github-actions github-actions bot locked and limited conversation to collaborators Mar 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
api A pull request containing changes affecting the API code. bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants