Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Factory Methods for Testing #84

Closed
white-alistair opened this issue May 27, 2022 · 2 comments
Closed

Factory Methods for Testing #84

white-alistair opened this issue May 27, 2022 · 2 comments
Labels
testing 🧪 How we test things and continuous integration

Comments

@white-alistair
Copy link
Member

For testing, it would be useful to have lightweight and minimal factory methods in the test directory which return a model initialised with realistic values (possibly from a previous run of the model), so you can just do, for example,

prog, diag, model = model_factory()

or

diag = diag_factory()

Much of this already exists, e.g. the initialize_from_rest method in prognostic_variables.jl, but it would be good to extend and formalise it.

@white-alistair white-alistair added the testing 🧪 How we test things and continuous integration label May 27, 2022
@milankl
Copy link
Member

milankl commented May 27, 2022 via email

@milankl
Copy link
Member

milankl commented Jun 16, 2022

Closing this as I believe initialize_speedy addresses that, feel free to reopen if that remains an issue.

@milankl milankl closed this as completed Jun 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
testing 🧪 How we test things and continuous integration
Projects
None yet
Development

No branches or pull requests

2 participants