Rename main script to "redux" to make it work in cmd. #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The batch scripts generated by "npm install" on Windows run the module using its actual filename, not the name of the installed binary. This means that argv[1] ends up being set to "index" and commander can't run any subcommands. Rename the main module to "redux" so that this matches.
Current coverage is 71.27%
@@ master #67 diff @@
==========================================
Files 11 11
Lines 344 275 -69
Methods 28 28
Messages 0 0
Branches 45 45
==========================================
- Hits 263 196 -67
+ Misses 81 79 -2
Partials 0 0
|
|
Awesome, thank you so much for this! Going to merge tonight when I get home on my personal computer |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The batch scripts generated by "npm install" on Windows run the module
using its actual filename, not the name of the installed binary. This
means that argv[1] ends up being set to "index" and commander can't run
any subcommands. Rename the main module to "redux" so that this matches.
Fixes #54.