Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Circumvent camera buffering and let the user handle EndOfStream #31

Merged
merged 3 commits into from
Jul 26, 2022

Conversation

Speykious
Copy link
Owner

Fixes #29 ... While waiting for SeeShark to have a good multithreaded system for the user to process received frames.

The method of waiting has been changed to accommodate for camera buffering and variable FPS.
Finally, an event handler for when the VideoStreamDecoder's decode loop hits EndOfStream has been added (previously, the user would just stop receiving frames without knowing why).

I'll note that there's probably something more useful than the DecodeStatus that we can send, as it will always be equal to DecodeStatus.EndOfStream...

@Speykious Speykious requested a review from adryzz July 26, 2022 21:34
Copy link
Collaborator

@adryzz adryzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Speykious Speykious merged commit 6a7ba43 into main Jul 26, 2022
@Speykious Speykious deleted the catching-up branch July 26, 2022 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants