Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BC-918 fix cancel coupon #48

Conversation

Viktorminator
Copy link
Contributor

Fix coupon canceling

@@ -64,7 +64,7 @@ public function cancelCoupon($basketId, string $couponCode, $userId)
"userId" => $userId
];

$response = $this->handler->handle('POST', $params, 'discard');
$response = $this->handler->handle('discardcoupon', $params);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First parameter is HTTP method


$response = $this->handler->handle('POST', $params, 'discard');
$response = $this->handler->handle('POST', $params);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you check it?
Now you miss part of URL
Please connect to Gateway and check from TEST

@ghost ghost force-pushed the master branch 2 times, most recently from f85974a to 0545cc6 Compare October 29, 2018 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants