fix: no async in filter #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This one took me really long to debug, but i was finally able to find out why a succesful verification event was emitted even though the presentation verification callback failed.
The filter that had an
asyncmethod doesn't really work, and thus it would see the returned promise value in the filter method as a truthy value (Boolean(Promise.reject())will still evaluate to true). It was especially weird since the error was thrown, but because it was not handled within a promise, it was an unhandled rejection.It does mean that the presentation verification callback has had no effect on the outcome of the verification, so this seems like a serious bug to get released as soon as possible.