Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added editor's color specification #7

Closed
wants to merge 1 commit into from
Closed

Added editor's color specification #7

wants to merge 1 commit into from

Conversation

poletaew
Copy link

@poletaew poletaew commented Nov 2, 2018

No description provided.

@Sphinxxxx
Copy link
Owner

Thanks, that's a useful feature!

However, I'm not sure about the name colorSpecification. It might sound like it affects more things than it does? For example, this won't change what's passed to the callbacks, nor does it restrict the syntax for input in the editor.

How about editorFormat? Any ideas?

@poletaew
Copy link
Author

poletaew commented Nov 6, 2018

Yeah, I doubted if it's correct property name.
editorFormat is much better.

@Sphinxxxx
Copy link
Owner

Published as editorFormat in v2.7.0

@Sphinxxxx Sphinxxxx closed this Nov 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@poletaew @Sphinxxxx