Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for downloading jar from external source #27

Closed
Osiris-Team opened this issue Sep 2, 2020 · 6 comments
Closed

Add support for downloading jar from external source #27

Osiris-Team opened this issue Sep 2, 2020 · 6 comments
Labels

Comments

@Osiris-Team
Copy link

Osiris-Team commented Sep 2, 2020

Currently this only supports downloading jars hosted on spigot directly.
Most of the jars are hosted externally and most of these links actually point directly to the jar.
That's why I think this feature would be very beneficial and worth implementing.

@InventivetalentDev
Copy link
Member

Downloads are a huge pain as it is, so I'm not gonna expand to external sources, sorry.

@Osiris-Team
Copy link
Author

Downloads are a huge pain as it is, so I'm not gonna expand to external sources, sorry.

F

@Osiris-Team
Copy link
Author

@InventivetalentDev How about I help you with that? Would it change your mind?

@Osiris-Team
Copy link
Author

@InventivetalentDev Huh. Did you change your mind? ahah: https://api.spiget.org/v2/resources/1997/download
ProtocolLib gets downloaded even though its external.

@InventivetalentDev
Copy link
Member

@Osiris-Team I didn't, sorry. They might've changed it to be external along the way.

@Osiris-Team
Copy link
Author

@InventivetalentDev Ok but that's not changing the fact, that it's working, haha!
Hope it stays this way lol

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants