Processor #7
Merged
Processor #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed Conflicts: SpiNNaker-machine/pom.xml SpiNNaker-utils/src/main/java/uk/ac/manchester/spinnaker/utils/package-info.java
dkfellows
previously requested changes
Jun 27, 2018
| + " cannot be less than or equal to zero"); | ||
| } | ||
| return new Processor(processorId, MachineDefaults.CLOCK_SPEED, | ||
| MachineDefaults.DTCM_AVAILABLE, isMonitor); |
There was a problem hiding this comment.
These two lines above are wrong. They don't use the clockSpeed or dtcmAvailable argument.
There was a problem hiding this comment.
hides head in shame.
| */ | ||
| public static final Processor factory(int processorId, boolean isMonitor) { | ||
| if (isMonitor) { | ||
| if (NON_MONITOR[processorId] == null) { |
There was a problem hiding this comment.
Finding monitor processors in a non-monitor array?
There was a problem hiding this comment.
good thing head already hidden.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a Processor