Merge pull request #529 from SpiNNakerManchester/roc_part

Typing information and some changes to make that easier

.coveragerc

@@ -14,3 +14,12 @@
 
 [run]
 branch = True
+
+[report]
+# Coverage should ignore overloads; they're not real code
+exclude_lines =
+    @overload
+    \.\.\.$
+    raise\s+NotImplementedError
+    if\s+TYPE_CHECKING:
+    #\s*(pragma|PRAGMA)[:\s]?\s*(no|NO)\s*(cover|COVER)

.github/workflows/python_actions.yml

@@ -45,6 +45,8 @@ jobs:
 
     - name: Install pip, etc
       uses: ./support/actions/python-tools
+    - name: Install mypy
+      run: pip install mypy
 
     - name: Install Spinnaker Dependencies
       uses: ./support/actions/install-spinn-deps
@@ -72,6 +74,9 @@ jobs:
         package: ${{ env.BASE_PKG }}
         language: en_GB
 
+    - name: Lint with mypy
+      run: mypy $BASE_PKG
+
   validate:
     runs-on: ubuntu-latest
     timeout-minutes: 10

.pylintrc

@@ -68,7 +68,9 @@ confidence=
 # --enable=similarities". If you want to run only the classes checker, but have
 # no Warning level messages displayed, use"--disable=all --enable=classes
 # --disable=W"
-disable=R,C
+disable=R,C,unsubscriptable-object
+# False positives for unsubscriptable-object. Mypy better at this class of issue
+# See https://github.com/pylint-dev/pylint/issues/1498
 
 # Enable the message, report, category or checker with the given id(s). You can
 # either give multiple identifier separated by comma (,) or put this option

pacman/config_setup.py

@@ -21,7 +21,7 @@
 BASE_CONFIG_FILE = "pacman.cfg"
 
 
-def unittest_setup():
+def unittest_setup() -> None:
     """
     Resets the configurations so only the local default configuration is
     included.
@@ -34,7 +34,7 @@ def unittest_setup():
     PacmanDataWriter.mock()
 
 
-def add_pacman_cfg():
+def add_pacman_cfg() -> None:
     """
     Add the local configuration and all dependent configuration files.
     """