Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Locate max cores of a chip #174

Merged
merged 5 commits into from
Jul 27, 2018
Merged

Locate max cores of a chip #174

merged 5 commits into from
Jul 27, 2018

Conversation

alan-stokes
Copy link
Contributor

this support the usage of sdram links etc much better, as we can now partition to a machine setup. Does assume that the spalloc max machine data is updated to include black listing

@coveralls
Copy link

Coverage Status

Coverage increased (+0.03%) to 64.525% when pulling 6df6f7e on locate_max_cores_of_a_chip into a03dc61 on master.

Copy link
Member

@rowleya rowleya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like it should work. My only comment is that this could also have been done like the SDRAM tracker with a ValueOrderedDict of _chip_n_cores[x, y]. This might be required in future if this seems to be slow when the number of cores increases.

@rowleya rowleya merged commit d1787bd into master Jul 27, 2018
@rowleya rowleya deleted the locate_max_cores_of_a_chip branch July 27, 2018 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants