-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Timestep changes #272
Closed
Closed
Timestep changes #272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Christian-B
added
enhancement
incomplete_left_for_further_release
Not ready for merging
labels
Nov 28, 2019
This was referenced Nov 28, 2019
Christian-B
changed the title
Replace the timestep params with simtime
Timestep changes
Feb 12, 2020
Christian-B
added
historic
Of historic interest only
and removed
incomplete_left_for_further_release
Not ready for merging
labels
Mar 31, 2021
Too many changes too complex to be worth it, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an alternative solution for different timesteps per vertex.
Before this PR is merged we need to decide.
The current state of the PR is to support both 1 and 2 as yes.
I @Christian-B prefer to force an ApplicationVertex to have just a single timestep which would require a cleanup here before merging.
Must be done at the same time as:
SpiNNakerManchester/SpiNNFrontEndCommon#528
SpiNNakerManchester/SpiNNakerGraphFrontEnd#134
SpiNNakerManchester/lab_answers#4
SpiNNakerManchester/sPyNNaker#749
SpiNNakerManchester/sPyNNaker8#317
SpiNNakerManchester/sPyNNakerNewModelTemplate#48
This effects a HUGH amount of stuff so I wonder if having different "timestep"s for different vertexes is a good idea.
An Alternative is to have only a single Python timestep which is used EVERYWHERE with the C code of the vertexes running at a different speed doing any conversions.
With possibly minimum python changes to make sure the runtime is rounded up to a lowestCommonMultiple of the C runtimesteps.