-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
convert 1D shape into largest perfect md shape possible #514
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No objections as long as it doesn't break any current tests.
Though perhaps a test could also be added using the script at http://spinnakermanchester.github.io/development/2d_convolutions.html |
This is only one of several options. Another is to keep as master and require the setting of max atoms. Another is to have 2D defaults |
I don't know how this was resolved so leaving it open and re-assigning it. |
Assume this is no longer needed. |
Yes, I think this was a test on the path, but is now no longer needed. |
Simplest version uses a m D shape with all sides the same size.
So 256 in 3D would be (6,6,6) where a shape of (7,6,6) would be possible