Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

convert 1D shape into largest perfect md shape possible #514

Closed
wants to merge 8 commits into from

Conversation

Christian-B
Copy link
Member

@Christian-B Christian-B commented May 3, 2023

Simplest version uses a m D shape with all sides the same size.

So 256 in 3D would be (6,6,6) where a shape of (7,6,6) would be possible

Copy link
Contributor

@andrewgait andrewgait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No objections as long as it doesn't break any current tests.

@andrewgait
Copy link
Contributor

Though perhaps a test could also be added using the script at http://spinnakermanchester.github.io/development/2d_convolutions.html

@Christian-B
Copy link
Member Author

This is only one of several options.

Another is to keep as master and require the setting of max atoms.

Another is to have 2D defaults

@andrewgait andrewgait assigned Christian-B and unassigned andrewgait Sep 28, 2023
@andrewgait
Copy link
Contributor

I don't know how this was resolved so leaving it open and re-assigning it.

@coveralls
Copy link

coveralls commented Sep 29, 2023

Coverage Status

coverage: 83.951% (+0.3%) from 83.65%
when pulling 3ee989d on md_default
into b9c1c42 on master.

@Christian-B
Copy link
Member Author

Assume this is no longer needed.

@rowleya
Copy link
Member

rowleya commented Nov 28, 2023

Yes, I think this was a test on the path, but is now no longer needed.

@rowleya rowleya closed this Nov 28, 2023
@rowleya rowleya deleted the md_default branch November 28, 2023 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants