Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

turn of validation of files used by JavaCaller #1032

Merged
merged 1 commit into from
Mar 17, 2023
Merged

Conversation

Christian-B
Copy link
Member

@Christian-B Christian-B commented Mar 17, 2023

Due to python-jsonschema/jsonschema#1059 jsonschema validation sometime fails.

This pr removes validation from normal run.
This will also provide a very minor speedup by removing an unlikely to be failed safety test

But keeps it when writing the json files as reports.
For example in debug mode which is tested by
spynnaker_integration_tests/test_debug_mode

@dkfellows
Copy link
Member

This looks OK in as far as it goes, but I want to know why we are having schemas cross threads. Is this just in testing?

@Christian-B
Copy link
Member Author

So far the error has only been spotted on Jenkins which is multi threaded.

But even there it happens in one or tow of several hundred runs so hard to be sure it could not happen elsewhere.

@dkfellows
Copy link
Member

Interesting. We're not passing any schema objects between threads ourselves. That's being done by some sort of cache within jsonschema.

Copy link
Member

@dkfellows dkfellows left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Acceptable workaround; jsonschema is more broken than I thought right now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants