Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes buffered out when using multiple runs #297

Merged
merged 1 commit into from
May 15, 2018

Conversation

rowleya
Copy link
Member

@rowleya rowleya commented Mar 9, 2018

Found this mostly by accident, but buffered read wasn't working when in multirun, as the buffered information wasn't reset correctly.

@rowleya rowleya added the bug There is a fault with the code label Mar 9, 2018
@rowleya rowleya requested a review from Christian-B March 9, 2018 14:49
Copy link
Member

@dkfellows dkfellows left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@dkfellows dkfellows merged commit ed30631 into master May 15, 2018
@dkfellows dkfellows deleted the fix_bufferd_out_multirun branch May 15, 2018 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug There is a fault with the code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants