Wrapped2 #110
Merged
Wrapped2 #110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 882
💛 - Coveralls |
Pull Request Test Coverage Report for Build 886
💛 - Coveralls |
This was referenced Jun 11, 2019
dkfellows
reviewed
Jun 12, 2019
|
|
||
| @property | ||
| def _unreachable_outgoing_chips(self): | ||
| def unreachable_outgoing_chips(self): |
There was a problem hiding this comment.
I wonder whether this (and unreachable_incoming_chips) ought to be done as generators rather than iterators.
dkfellows
reviewed
Jun 12, 2019
dkfellows
approved these changes
Jun 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes machine repair rather than machine mutible
add_fpga_links add_spinnaker_links dont need to be told the board version. Machine knows that!
Must be done at the same time as:
SpiNNakerManchester/PACMAN#228
SpiNNakerManchester/SpiNNFrontEndCommon#439
SpiNNakerManchester/SpiNNMan#164
SpiNNakerManchester/SpiNNakerGraphFrontEnd#109