Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version248 #260

Merged
merged 20 commits into from
Apr 30, 2024
Merged

Version248 #260

merged 20 commits into from
Apr 30, 2024

Conversation

Christian-B
Copy link
Member

@Christian-B Christian-B commented Apr 26, 2024

n_cores on a spin2 board changed to 153 adding 0 as the none quad scamp core

added view.get_physical_quad function to go from virtual p to qx, qy and qp

view,get_physical_core_string now get_physical_string

  • also works with get_physical_quad

Adds a Version for a Spin2 48 Chip board/

Adds an Abstract class handle code shared by spin1 and spin2 48 Chip boards
Adds an Abstract class for code shared by a 1 and 48 Chip spin 2 board.

FGA and Spinnaker Links NOT DONE!

Version wildcard changed
ANY, FOUR_PLUS, BIG now included the Spin2 48 Chip version

MULTIPLE_BOARDS and WRAPPABLE removed

EIGHT_BY_EIGHT

  • added for tests with hard coded chips of placements
  • includes both Spin1 and Spin2 48 Chip
  • Only need to be changed of we have a different size spin2 board

WITH_FPGAS

  • test that check or use FPGA or SPiNNAKEr links
  • only spin1 as these are not done on Spin2 YET!

Lots of tests adjusted.
Test commented out are todo
Tests removed have been moved or are duplicates

Must be done at the same time as:
SpiNNakerManchester/SpiNNMan#400
SpiNNakerManchester/PACMAN#559
SpiNNakerManchester/SpiNNFrontEndCommon#1182
SpiNNakerManchester/sPyNNaker#1447
tested by
SpiNNakerManchester/IntegrationTests#269

@coveralls
Copy link

coveralls commented Apr 26, 2024

Coverage Status

coverage: 92.315% (-0.4%) from 92.696%
when pulling a825f28 on version248
into ffead2a on master.

@rowleya rowleya merged commit 5fe136c into master Apr 30, 2024
9 checks passed
@rowleya rowleya deleted the version248 branch April 30, 2024 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants