Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update add_fpga_links to remove use of lists #77

Merged
merged 5 commits into from
Feb 12, 2019
Merged

Update add_fpga_links to remove use of lists #77

merged 5 commits into from
Feb 12, 2019

Conversation

andrewgait
Copy link
Contributor

Fixing point 1 of #75 to remove unnecessary use of lists

  • edit to remove mixed directional notation as well (should either be North/South/East/West or Top/Bottom/Left/Right)

@andrewgait
Update add_fpga_links to remove use of lists
745a2ef 
- edit to remove mixed directional notation as well
@andrewgait andrewgait added this to the 5.0.0 milestone Jul 4, 2018
Christian-B
Christian-B approved these changes Jul 4, 2018
View reviewed changes
Copy link
Member

@Christian-B Christian-B left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@Christian-B
Copy link
Member

Christian-B commented Jul 4, 2018 •
edited
Loading

@alan-stokes could you run a few tests on your toroid?

@coveralls
Copy link

coveralls commented Jul 4, 2018 •
edited
Loading

Pull Request Test Coverage Report for Build 723

  • 25 of 25 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.3%) to 94.134%
Totals Coverage Status
Change from base Build 718: -0.3%
Covered Lines: 995
Relevant Lines: 1057
💛 - Coveralls

@rowleya rowleya merged commit f9b9543 into master Feb 12, 2019
@rowleya rowleya deleted the update_add_fpga_links branch February 12, 2019 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Christian-B Christian-B Christian-B approved these changes

@rowleya rowleya Awaiting requested review from rowleya

@alan-stokes alan-stokes Awaiting requested review from alan-stokes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
5.0.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@andrewgait @Christian-B @coveralls @rowleya