Merge pull request #260 from SpiNNakerManchester/pylint

Pylint
SpiNNakerManchester · Jan 18, 2022 · 6d779a8 · 6d779a8
2 parents 4f2beb8 + 3d35186
commit 6d779a8
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 4 deletions.
diff --git a/spinnman/connections/scp_request_pipeline.py b/spinnman/connections/scp_request_pipeline.py
@@ -127,7 +127,7 @@ def _get_next_sequence_number(self):
         :return: The next number in the sequence.
         :rtype: int
         """
-        global _next_sequence, _next_sequence_lock
+        global _next_sequence
         with _next_sequence_lock:
             sequence = _next_sequence
             _next_sequence = (sequence + 1) % MAX_SEQUENCE

diff --git a/spinnman/processes/get_machine_process.py b/spinnman/processes/get_machine_process.py
@@ -526,5 +526,5 @@ def _report_ignore(self, message, *args):
                 self._report_file = join(
                     self._default_report_directory, REPORT_FILE)
 
-        with open(self._report_file, "a") as r_file:
+        with open(self._report_file, "a", encoding="utf-8") as r_file:
             r_file.write(full_message)
diff --git a/spinnman/utilities/locate_connected_machine_ip_address.py b/spinnman/utilities/locate_connected_machine_ip_address.py
@@ -55,7 +55,7 @@ def _ctrlc_handler(sig, frame):  # @UnusedVariable
     def _print_connected(ip_address, timestamp):
         try:
             hostname = f" ({socket.gethostbyaddr(ip_address)[0]})"
-        except Exception:
+        except Exception:  # pylint: disable=broad-except
             hostname = ""
         print(f"{ip_address}{hostname} at {timestamp}")
         return False

diff --git a/spinnman/utilities/reports.py b/spinnman/utilities/reports.py
@@ -35,7 +35,7 @@ def generate_machine_report(report_directory, machine, connections):
     file_name = os.path.join(report_directory, _REPORT_NAME)
     time_date_string = time.strftime("%c")
     try:
-        with open(file_name, "w") as f:
+        with open(file_name, "w", encoding="utf-8") as f:
             _write_header(f, time_date_string, machine, connections)
             # TODO: Add further details on the target machine.
             for chip in machine.chips: