Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transceiver by version #354

Merged
merged 55 commits into from
Oct 11, 2023
Merged

Transceiver by version #354

merged 55 commits into from
Oct 11, 2023

Conversation

Christian-B
Copy link
Member

@Christian-B Christian-B commented Aug 4, 2023

Preparation work for Different Transceivers by Version.

There is an AbstractTransciever Which is just an API
A BaseTransceiver which holds the shared coded
There is highly likely going to be another Spin1/spin2 layer between base and specific
Then Version3 and Version5 Transceivers.

There is also a MockableTrableTransceiver to Extend in Unittets

There is also Extended Classes so that the ExtendedTranceiver can be any version

The selection of which Transceiver to use is done by methods in tranceiver_factory.

Must be done at the same time as:
SpiNNakerManchester/SpiNNFrontEndCommon#1099
SpiNNakerManchester/sPyNNaker#1376

Tested by:
SpiNNakerManchester/IntegrationTests#224

@dkfellows
Copy link
Member

Looking good in principle, but I'm on my phone so I can't be more thorough than that for now. 😁

I'd be tempted to call the abstract class just Transceiver to minimise the amount of fixing up of comments (and type annotations on my branches) as there really aren't very many places that make transceivers but an awful lot more that use them.

@Christian-B
Copy link
Member Author

Looking good in principle, but I'm on my phone so I can't be more thorough than that for now. 😁

I'd be tempted to call the abstract class just Transceiver to minimise the amount of fixing up of comments (and type annotations on my branches) as there really aren't very many places that make transceivers but an awful lot more that use them.

That makes a lot of sense and one I wondered about.
I intentional did not while working on it to be sure to change all places used in code.

@dkfellows dkfellows added this to the 7.1.0 milestone Sep 27, 2023
@rowleya rowleya merged commit e23c8fe into master Oct 11, 2023
8 checks passed
@rowleya rowleya deleted the transceiver_by_version branch October 11, 2023 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants