-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Transceiver by version #354
Conversation
Looking good in principle, but I'm on my phone so I can't be more thorough than that for now. 😁 I'd be tempted to call the abstract class just |
That makes a lot of sense and one I wondered about. |
Preparation work for Different Transceivers by Version.
There is an AbstractTransciever Which is just an API
A BaseTransceiver which holds the shared coded
There is highly likely going to be another Spin1/spin2 layer between base and specific
Then Version3 and Version5 Transceivers.
There is also a MockableTrableTransceiver to Extend in Unittets
There is also Extended Classes so that the ExtendedTranceiver can be any version
The selection of which Transceiver to use is done by methods in tranceiver_factory.
Must be done at the same time as:
SpiNNakerManchester/SpiNNFrontEndCommon#1099
SpiNNakerManchester/sPyNNaker#1376
Tested by:
SpiNNakerManchester/IntegrationTests#224