Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

simplify the spalloc keep alive #401

Merged
merged 6 commits into from
May 15, 2024
Merged

simplify the spalloc keep alive #401

merged 6 commits into from
May 15, 2024

Conversation

Christian-B
Copy link
Member

@Christian-B Christian-B commented May 14, 2024 •
edited
Loading

The current keep alive cause errors in windows.

This pr simplifies it to use simple threads.

  1. A job when creates starts its own keepalive without being asked to
  2. The keepalive is a simple thread started by the init
  3. The job's destroy method will unset the keepalive url which is the flag for the thread to stop

added a script to get job with a triad.

Must be done at the same time as:
SpiNNakerManchester/SpiNNFrontEndCommon#1187
SpiNNakerManchester/sPyNNaker#1453

tested by:
SpiNNakerManchester/microcircuit_model#38
SpiNNakerManchester/IntegrationTests#275

@Christian-B
simplify keep_alive
0f8dfcf
@Christian-B
add typing
b89c3f4 
more typing

flake8

typing fix

copyright
This was referenced May 14, 2024
Merged
Merged
Closed
Closed
@Christian-B Christian-B marked this pull request as draft May 15, 2024 10:41
@Christian-B
Copy link
Member Author

fixes: #402

@Christian-B Christian-B marked this pull request as ready for review May 15, 2024 11:08
@coveralls
Copy link

Coverage Status

coverage: 59.03% (+0.03%) from 58.998%
when pulling 6a20a4f on keep_alive
into cdfc5e4 on master.

@rowleya rowleya merged commit dab1e4e into master May 15, 2024
9 checks passed
@rowleya rowleya deleted the keep_alive branch May 15, 2024 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Christian-B @coveralls @rowleya