Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

overides type check should allow methods to return None (or not) #265

Merged
merged 3 commits into from
Jan 16, 2024

Conversation

Christian-B
Copy link
Member

In mypy declaring a None return is Optional.
An exception is that if there are no prams a None declaration is needed to trigger type checking

We had choose the style of not declaring the None return

Previously the overrides check had forced both overrider and overwriten to either both or neither to declare the None return

This pr allows one to declare a None return and the other not to.

@coveralls
Copy link

Coverage Status

coverage: 88.275% (+0.1%) from 88.179%
when pulling caaf714 on allow_none
into e13f213 on master.

@rowleya rowleya merged commit 0302811 into master Jan 16, 2024
9 checks passed
@rowleya rowleya deleted the allow_none branch January 16, 2024 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants