Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add class property #64

Merged
merged 1 commit into from
Sep 25, 2018
Merged

Add class property #64

merged 1 commit into from
Sep 25, 2018

Conversation

rowleya
Copy link
Member

@rowleya rowleya commented Jul 7, 2018

Add a @classproperty decorator, allowing for properties at the class-level

@coveralls
Copy link

Pull Request Test Coverage Report for Build 552

  • 6 of 22 (27.27%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.8%) to 92.042%
Changes Missing Coverage Covered Lines Changed/Added Lines %
spinn_utilities/classproperty.py 6 22 27.27%
Totals Coverage Status
Change from base Build 540: -0.8%
Covered Lines: 1573
Relevant Lines: 1709
💛 - Coveralls

@rowleya rowleya merged commit cd87ca9 into master Sep 25, 2018
@dkfellows
Copy link
Member

That's a good idea. The implementation has some non-obvious aspects, but that's Python...

@alan-stokes alan-stokes deleted the add_class_property branch October 1, 2018 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Christian-B Christian-B Awaiting requested review from Christian-B

@dkfellows dkfellows Awaiting requested review from dkfellows

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rowleya @coveralls @dkfellows